----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53535 -----------------------------------------------------------
Ship it! LGTM, but as always let's definitely resolve the two issues before committing. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/24776/#comment93231> Hmm, these are a wierd semantics ... can you please document the construct sufficiently about this (that it also gets terminated in the destructor). src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/24776/#comment93235> Why is this '* 2'? This raises my eyebrow that you had to do this to get the test to deterministically pass which makes me wonder if we're not waiting for all the right conditions and we could still have a non-deterministic failure if timing doesn't work out. We try and avoid these kind of constants in order to make our tests as deterministic as possible. - Benjamin Hindman On Sept. 15, 2014, 8:33 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24776/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 8:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/24776 > > > Diffs > ----- > > src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f > src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a > src/tests/docker_containerizer_tests.cpp > 8654f9c787bd207f6a7b821651e0c083bea9dc8a > > Diff: https://reviews.apache.org/r/24776/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
