> On Sept. 9, 2014, 6:15 p.m., Benjamin Hindman wrote: > > Why did you need to mock DockerContainerizerProcess in order to write these > > tests? Couldn't you have just used the existing MockDockerContainerizer? > > Timothy Chen wrote: > I wanted to simulate having destroy called in a pull/fetching state, so I > thought the only way to do so is to mock the process since the callbacks are > on DockerContainerizerProcess and not the Containerizer, so the callbacks for > fetch and pull blocks and I can call destroy in that state and verify it was > able to destroy.
Yup yup, you're correct, my apologies! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review52758 ----------------------------------------------------------- On Sept. 15, 2014, 8:33 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24776/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 8:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/24776 > > > Diffs > ----- > > src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f > src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a > src/tests/docker_containerizer_tests.cpp > 8654f9c787bd207f6a7b821651e0c083bea9dc8a > > Diff: https://reviews.apache.org/r/24776/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
