----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review54238 -----------------------------------------------------------
Ship it! Looks great! A few minor nits and a request for a comment. I'd be willing to commit this unless @benjaminhindman has any objections. 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/25789/#comment94247> Nit: You only need single-spacing between a namespace opening and the first code inside it. 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/25789/#comment94248> Also don't need double-spacing here (but do below it, I believe) 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/25789/#comment94249> Maybe you could comment why there are two THeads here (for disambiguating from the Iterable version below)? So the next time somebody looks at this they'll know why/how not to change it. 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp <https://reviews.apache.org/r/25789/#comment94250> s/narly/gnarly/? - Adam B On Sept. 22, 2014, 10:30 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25789/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 10:30 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Add Variadic strings join. > There is a second version of the variadic join which takes a reference to a > stringstream as a parameter. This is handy when strings::join is just a part > of a larger string manipulation. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 > > Diff: https://reviews.apache.org/r/25789/diff/ > > > Testing > ------- > > Ran make check for stout. Added test cases for join as these were missing. > > > Thanks, > > Joris Van Remoortere > >
