----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review54549 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/25789/#comment94723> Very useful comment, thanks Joris! 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/25789/#comment94722> Silly style thing, please move 'stream' to newline. 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp <https://reviews.apache.org/r/25789/#comment94720> Just a style thing, we tend to declare/define as close to where they're used as possible (i.e., not C style). 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp <https://reviews.apache.org/r/25789/#comment94721> Silly style thing, but in this case both arguments should be indented the same. - Benjamin Hindman On Sept. 25, 2014, 5:10 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25789/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 5:10 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Add Variadic strings join. > There is a second version of the variadic join which takes a reference to a > stringstream as a parameter. This is handy when strings::join is just a part > of a larger string manipulation. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 > > Diff: https://reviews.apache.org/r/25789/diff/ > > > Testing > ------- > > Ran make check for stout. Added test cases for join as these were missing. > > > Thanks, > > Joris Van Remoortere > >
