----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/#review55028 -----------------------------------------------------------
LGTM. The only concern I have is about the truncate() (see my comments). I'll give a shipit once the configure.ac issue is resolved. src/Makefile.am <https://reviews.apache.org/r/24536/#comment95363> Ditto my comments on the other review. You might wanna modify configure.ac. src/state/log.cpp <https://reviews.apache.org/r/24536/#comment95452> Could you please add a comment about why you wanna skip snapshots with diffs (it's not obvious to me)? Also, could you also comment on why this won't cause garbage collection issue? For example, what if all snapshots have diffs > 0? - Jie Yu On Sept. 29, 2014, 12:45 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24536/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 12:45 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > Note that this hard codes the location of the subversion and Apache Portable > Runtime (APR) headers. > > > Diffs > ----- > > src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b > src/messages/state.proto 59276e55fcbebdb754c20d39b13b402fd11c3dad > src/state/log.cpp fd8b28a0b5d14f5ba3e6fde4695f6d09acf9c56a > > Diff: https://reviews.apache.org/r/24536/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
