> On Oct. 18, 2014, 9:42 p.m., Ben Mahler wrote: > > src/state/log.cpp, lines 370-373 > > <https://reviews.apache.org/r/24536/diff/5/?file=725137#file725137line370> > > > > This comment looks like a leftover from the bug in the last diff? > > > > We won't find a minimum now, only when there are no shapshots.
This is still a very valid TODO, we'll just always have a minimum, so I updated the first sentence. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/#review57282 ----------------------------------------------------------- On Oct. 25, 2014, 11:18 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24536/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 11:18 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > Note that this hard codes the location of the subversion and Apache Portable > Runtime (APR) headers. > > > Diffs > ----- > > src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 > src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION > src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION > src/messages/state.proto 59276e55fcbebdb754c20d39b13b402fd11c3dad > src/state/log.hpp 6bd054fcd1cf79a2ad1a59da59c9a903cb25882f > src/state/log.cpp fd8b28a0b5d14f5ba3e6fde4695f6d09acf9c56a > src/tests/state_tests.cpp 0948b9fb7d1c378f8c90abc85b34773a6963d91f > > Diff: https://reviews.apache.org/r/24536/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
