> On Sept. 29, 2014, 5:25 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1752 > > <https://reviews.apache.org/r/26090/diff/2/?file=707526#file707526line1752> > > > > Why the change in log message, it does't make sense now? e.g., "The > > launcher for updating container abc123 1"
WSTRINGIFY is better as it actually does a status2str interpretation. The log message connects with its output. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26090/#review54828 ----------------------------------------------------------- On Oct. 1, 2014, 6:01 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26090/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 6:01 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: mesos-1808 > https://issues.apache.org/jira/browse/mesos-1808 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > include/mesos/mesos.proto 735da53 > src/slave/containerizer/isolators/network/helper.cpp 6cbcb33 > src/slave/containerizer/isolators/network/port_mapping.hpp 2395ec2 > src/slave/containerizer/isolators/network/port_mapping.cpp 8ddfb18 > src/tests/port_mapping_tests.cpp 0389f40 > > Diff: https://reviews.apache.org/r/26090/diff/ > > > Testing > ------- > > both manually tested and with a unit test. > > > Thanks, > > Chi Zhang > >
