-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/#review55100
-----------------------------------------------------------
Bad patch!
Reviews applied: [26236, 26090]
Failed command: ./support/mesos-style.py
Error:
Checking 510 files using filter
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/linux/routing/diagnosis/diagnosis.hpp:59: Namespace should be terminated
with "// namespace state {" [readability/namespace] [5]
Total errors found: 1
- Mesos ReviewBot
On Oct. 1, 2014, 6:01 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26090/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 6:01 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: mesos-1808
> https://issues.apache.org/jira/browse/mesos-1808
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 735da53
> src/slave/containerizer/isolators/network/helper.cpp 6cbcb33
> src/slave/containerizer/isolators/network/port_mapping.hpp 2395ec2
> src/slave/containerizer/isolators/network/port_mapping.cpp 8ddfb18
> src/tests/port_mapping_tests.cpp 0389f40
>
> Diff: https://reviews.apache.org/r/26090/diff/
>
>
> Testing
> -------
>
> both manually tested and with a unit test.
>
>
> Thanks,
>
> Chi Zhang
>
>
