> On Oct. 1, 2014, 9:49 p.m., Cody Maloney wrote: > > 3rdparty/libprocess/include/process/async.hpp, line 123 > > <https://reviews.apache.org/r/26246/diff/1/?file=710330#file710330line123> > > > > Why change the comment style here?
There were 2 versions of a function with this line, except one had a `//` comment and `/* */` comment. It just happened so that the one I kept had the `/* */` comment. Changed to `//` comment. > On Oct. 1, 2014, 9:49 p.m., Cody Maloney wrote: > > 3rdparty/libprocess/include/process/async.hpp, line 124 > > <https://reviews.apache.org/r/26246/diff/1/?file=710330#file710330line124> > > > > Shouldn't this be a std::forward? (Both here and below in > > AsyncExecutor::execute). It was `std::move` because the arguments were being passed by value i.e. `As... as` rather than `As&&... as`. The reason for that was because I was using the `As...` to explicitly instantiate a template. I've changed it to be `As&&...` now and use `std::forward`. > On Oct. 1, 2014, 9:49 p.m., Cody Maloney wrote: > > 3rdparty/libprocess/include/process/c++11/defer.hpp, line 254 > > <https://reviews.apache.org/r/26246/diff/1/?file=710331#file710331line254> > > > > The joys of not having C++14 :P Yep... > On Oct. 1, 2014, 9:49 p.m., Cody Maloney wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, line 850 > > <https://reviews.apache.org/r/26246/diff/1/?file=710340#file710340line850> > > > > Is it possible to do this without having to change naming to > > disambiguate the overloads? Reverted to just `run` and `static_cast` to pick the overload. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26246/#review55138 ----------------------------------------------------------- On Oct. 5, 2014, 5:23 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26246/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2014, 5:23 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > With variadic template support now required in Mesos, the preprocessor > expansion technique is no longer necessary. > For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and > `executor.hpp`, there are 2 separate versions. > I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` > directory but left the pre-c++11 versions alone. > There are implementation details that make the pre-c++11 versions more tricky > to fix and I believe it's better to just let them obselete out. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/async.hpp > 9af3cc07334eb7dc26b73964c447cc9b9799396c > 3rdparty/libprocess/include/process/c++11/defer.hpp > 7b4dd07696748f2e2e20add62ecd554da516ae8f > 3rdparty/libprocess/include/process/c++11/deferred.hpp > 352205b835bd969d9560f2319e8e9d2b2f14d17b > 3rdparty/libprocess/include/process/c++11/delay.hpp > 5f686db1df50829a5aad76eb91ea6a86e8969c1d > 3rdparty/libprocess/include/process/c++11/dispatch.hpp > 76da2828cf36b6143d627dac66f3e0cc4416bae4 > 3rdparty/libprocess/include/process/c++11/executor.hpp > 157a1d29fa6e64f823b0ab40ec51889bf8947f60 > 3rdparty/libprocess/include/process/future.hpp > 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf > 3rdparty/libprocess/include/process/help.hpp > 07e99f1124c60003f4c8b8e6cdcb193bb3577496 > 3rdparty/libprocess/include/process/run.hpp > 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042 > 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c > 3rdparty/libprocess/src/tests/process_tests.cpp > b985fb77ea05fae5c0b144ea48814acc7bb5135b > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29 > > Diff: https://reviews.apache.org/r/26246/diff/ > > > Testing > ------- > > `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, > `clang-3.3` and `clang-3.5` > > > Thanks, > > Michael Park > >
