-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
-----------------------------------------------------------

(Updated Oct. 5, 2014, 7:35 a.m.)


Review request for mesos and Dominic Hamon.


Changes
-------

GCC-4.8 complains about not having `this->`


Repository: mesos-git


Description
-------

With variadic template support now required in Mesos, the preprocessor 
expansion technique is no longer necessary.
For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and 
`executor.hpp`, there are 2 separate versions.
I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` 
directory but left the pre-c++11 versions alone.
There are implementation details that make the pre-c++11 versions more tricky 
to fix and I believe it's better to just let them obselete out.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/async.hpp 
9af3cc07334eb7dc26b73964c447cc9b9799396c 
  3rdparty/libprocess/include/process/c++11/defer.hpp 
7b4dd07696748f2e2e20add62ecd554da516ae8f 
  3rdparty/libprocess/include/process/c++11/deferred.hpp 
352205b835bd969d9560f2319e8e9d2b2f14d17b 
  3rdparty/libprocess/include/process/c++11/delay.hpp 
5f686db1df50829a5aad76eb91ea6a86e8969c1d 
  3rdparty/libprocess/include/process/c++11/dispatch.hpp 
76da2828cf36b6143d627dac66f3e0cc4416bae4 
  3rdparty/libprocess/include/process/c++11/executor.hpp 
157a1d29fa6e64f823b0ab40ec51889bf8947f60 
  3rdparty/libprocess/include/process/future.hpp 
46ae16b0bbce79005f5ed8711be663eeeb8f4bcf 
  3rdparty/libprocess/include/process/help.hpp 
07e99f1124c60003f4c8b8e6cdcb193bb3577496 
  3rdparty/libprocess/include/process/run.hpp 
924d31a7d1bba0a6ecd8be8d622a3ae1faebe042 
  3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c 
  3rdparty/libprocess/src/tests/process_tests.cpp 
b985fb77ea05fae5c0b144ea48814acc7bb5135b 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29 
  3rdparty/libprocess/src/tests/timeseries_tests.cpp 
fd906b869e8bbf5c07c67c5319dec82681e811b7 

Diff: https://reviews.apache.org/r/26246/diff/


Testing
-------

`make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` 
and `clang-3.5`


Thanks,

Michael Park

Reply via email to