> On Oct. 2, 2014, 9:39 p.m., Ben Mahler wrote: > > Any reason why there's no bundled version for these, like we did for other > > libraries? > > > > I don't see this on my Mac and would like to avoid needing a special > > ./configure flag. > > Timothy Chen wrote: > I was wondering if I should bundle it or not as well. Do we have a > guideline what we usually bundle and what we usually don't? > > Timothy Chen wrote: > I'm actually able to help use brew install and not use any special flags > on mac. I can give out more instructions later too. > I don't think we really need to bundle this since it's available packages > on linux and mac.
I'd love to avoid bundling this if possible, just like we avoid bundling SASL. One alternative would be to conditionally compile the code that uses this, but in the long run the plan is to avoid bundling all together! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26214/#review55251 ----------------------------------------------------------- On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26214/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 7:06 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Able to build with OSX and Ubuntu 14.04. > > (Needed to specific --with-svn with OSX since it's installed in usr/local > with brew) > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION > 3rdparty/libprocess/configure.ac 501de40 > configure.ac 86d448c > src/Makefile.am 27c42df > > Diff: https://reviews.apache.org/r/26214/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
