----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26214/#review55532 -----------------------------------------------------------
Ship it! configure.ac <https://reviews.apache.org/r/26214/#comment95907> Let's avoid the extra APR_CFLAGS variable and just set CPPFLAGS in both the branches. Same below with SVN_CFLAGS (and in the libprocess configure.ac too). - Benjamin Hindman On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26214/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 7:06 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Able to build with OSX and Ubuntu 14.04. > > (Needed to specific --with-svn with OSX since it's installed in usr/local > with brew) > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION > 3rdparty/libprocess/configure.ac 501de40 > configure.ac 86d448c > src/Makefile.am 27c42df > > Diff: https://reviews.apache.org/r/26214/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
