> On Oct. 6, 2014, 7:25 a.m., Bernd Mathiske wrote: > > src/examples/test_module.hpp, line 26 > > <https://reviews.apache.org/r/25848/diff/14/?file=713787#file713787line26> > > > > Now there is a confusion whether TestModule is "the module" or > > exampleModule is "the module". I suggest we only call one of the two "the > > module". Since "Isolator", etc. aren't called module (which is good, as > > their module-ness should not matter at their use sites), I would opt for > > renaming TestModule. Suggestion: TestCalculator.
"TestModule" is along the same lines as TestFramework, TestExecutor, etc. Is there a better name then "exampleModule"? > On Oct. 6, 2014, 7:25 a.m., Bernd Mathiske wrote: > > src/module/manager.cpp, line 229 > > <https://reviews.apache.org/r/25848/diff/14/?file=713790#file713790line229> > > > > Can we use a dynamic_cast here for added safety? This means that > > ModuleBase becomes an abstract class with a virtual method, though. We > > could make "compatible" that method. Instead of a bool it would return an > > Option<bool>. A "none" result would then take over the role of the methid > > being NULL. In ModuleBase, "compatible" is merely a function pointer, not a function and so it doesn't make sense to include a virtual method here. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review55487 ----------------------------------------------------------- On Oct. 7, 2014, 6:43 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25848/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 6:43 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, > and Timothy St. Clair. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Adding a first class primitive, abstraction and process for dynamic library > writing and loading can make it easier to extend inner workings of Mesos. > Making it possible to have dynamic loadable resource allocators, isolators, > containerizes, authenticators and much more. > > > Diffs > ----- > > include/mesos/module.hpp PRE-CREATION > src/Makefile.am c62a974dcc80f3c3dd6060aee51f8367a0abe724 > src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 > src/examples/example_module_impl.cpp PRE-CREATION > src/examples/test_module.hpp PRE-CREATION > src/messages/messages.proto 9ff06b38086010df362036c695a5222371f70f4d > src/module/manager.hpp PRE-CREATION > src/module/manager.cpp PRE-CREATION > src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b > src/tests/module_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25848/diff/ > > > Testing > ------- > > Ran make check with added tests for verifying library/module loading and > simple version check. > > > Thanks, > > Kapil Arya > >
