> On Oct. 7, 2014, 7:43 p.m., Michael Park wrote: > > src/module/manager.hpp, line 75 > > <https://reviews.apache.org/r/25848/diff/17/?file=714903#file714903line75> > > > > Is the result of `module->create()` supposed to be a singleton? As in, > > if we call `create` twice with the same module name, should we end up with > > a pointer to a singleton? or is it supposed to return a pointer to a new > > instance?
Mesos is not imposing any restriction and it is upto the module writer to decide. AFAIK, for our current use cases, we won't be calling create() twice on the same module. However, one can imagine use cases where multiple modules are created by passing different arguments to create(). - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review55732 ----------------------------------------------------------- On Oct. 7, 2014, 7:07 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25848/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 7:07 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, > and Timothy St. Clair. > > > Bugs: MESOS-1384 > https://issues.apache.org/jira/browse/MESOS-1384 > > > Repository: mesos-git > > > Description > ------- > > Adding a first class primitive, abstraction and process for dynamic library > writing and loading can make it easier to extend inner workings of Mesos. > Making it possible to have dynamic loadable resource allocators, isolators, > containerizes, authenticators and much more. > > > Diffs > ----- > > include/mesos/module.hpp PRE-CREATION > src/Makefile.am c62a974dcc80f3c3dd6060aee51f8367a0abe724 > src/examples/example_module_impl.cpp PRE-CREATION > src/examples/test_module.hpp PRE-CREATION > src/messages/messages.proto 9ff06b38086010df362036c695a5222371f70f4d > src/module/manager.hpp PRE-CREATION > src/module/manager.cpp PRE-CREATION > src/tests/master_tests.cpp 705e5f2c0f9d693946e722cef63f38f3bff0d46b > src/tests/module_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25848/diff/ > > > Testing > ------- > > Ran make check with added tests for verifying library/module loading and > simple version check. > > > Thanks, > > Kapil Arya > >
