> On Oct. 9, 2014, 4:41 a.m., Jie Yu wrote: > > Flying by. You may wanna take a look at: > > https://github.com/facebook/folly/blob/master/folly/Optional.h > > > > Not sure if we can use unstricted union? Does g++44 supports that?
According to https://gcc.gnu.org/projects/cxx0x.html unrestricted unions are supported from gcc4.6+. In-place new is an old c-ism. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26476/#review55951 ----------------------------------------------------------- On Oct. 9, 2014, 1:35 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26476/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 1:35 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Remove dynamic allocations from Option class. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 47fe92c > > Diff: https://reviews.apache.org/r/26476/diff/ > > > Testing > ------- > > make check > support/mesos-style.py > valgrind (reduced allocation count) > > > Thanks, > > Joris Van Remoortere > >
