> On Oct. 9, 2014, 7:55 p.m., Timothy Chen wrote: > > src/tests/master_tests.cpp, line 265 > > <https://reviews.apache.org/r/25250/diff/6/?file=716710#file716710line265> > > > > Perhaps you should do EXPECT so you can cleanly shutdown in the end.
If the response has not been parsed successfully, the test will fail right after. Same holds for assertions below. I mark this as "dropped", but feel free to reopen if I vioalte the guidline or we have an agreed way to act here. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review56041 ----------------------------------------------------------- On Oct. 9, 2014, 5:05 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25250/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 5:05 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-1736 > https://issues.apache.org/jira/browse/MESOS-1736 > > > Repository: mesos-git > > > Description > ------- > > When a framework is shut down e.g. by calling driver.stop() from the > scheduler, running tasks are marked KILLED before migrating them to completed. > > > Diffs > ----- > > src/master/master.cpp cb46cec > src/tests/master_tests.cpp d9dc40c > > Diff: https://reviews.apache.org/r/25250/diff/ > > > Testing > ------- > > make check (OS X) > > > Thanks, > > Alexander Rukletsov > >
