----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review57771 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/25250/#comment98651> s/descrptive/descriptive/ src/tests/master_tests.cpp <https://reviews.apache.org/r/25250/#comment98652> Why 'auto' instead of 'Offer'? Only saves 1 character of typing. src/tests/master_tests.cpp <https://reviews.apache.org/r/25250/#comment98653> Wrap after the '=' instead of between values.find, if possible src/tests/master_tests.cpp <https://reviews.apache.org/r/25250/#comment98654> Wrap after '=' - Adam B On Oct. 10, 2014, 7:15 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25250/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 7:15 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-1736 > https://issues.apache.org/jira/browse/MESOS-1736 > > > Repository: mesos-git > > > Description > ------- > > When a framework is shut down e.g. by calling driver.stop() from the > scheduler, running tasks are marked KILLED before migrating them to completed. > > > Diffs > ----- > > src/master/master.cpp cb46cec > src/tests/master_tests.cpp d9dc40c > > Diff: https://reviews.apache.org/r/25250/diff/ > > > Testing > ------- > > make check (OS X, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >