----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26723/#review56649 -----------------------------------------------------------
Ship it! Great explanation. Go ahead and link that JIRA to the Review Request. Minor nits, then we can commit. 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp <https://reviews.apache.org/r/26723/#comment97041> I think we'd usually add another newline between here. 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp <https://reviews.apache.org/r/26723/#comment97042> Can this not be const std::string& ? - Adam B On Oct. 14, 2014, 6:12 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26723/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 6:12 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos-git > > > Description > ------- > > All strings in JSON need to be escaped, including the keys in dictionaries / > objects. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 719aa964a536cf02dbd2de440157de487ec703b1 > > Diff: https://reviews.apache.org/r/26723/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Cody Maloney > >
