> On Oct. 15, 2014, 4:14 a.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 315 > > <https://reviews.apache.org/r/26723/diff/1/?file=721230#file721230line315> > > > > Can this not be const std::string& ?
Good catch - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26723/#review56649 ----------------------------------------------------------- On Oct. 15, 2014, 6 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26723/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 6 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-1878 > https://issues.apache.org/jira/browse/MESOS-1878 > > > Repository: mesos-git > > > Description > ------- > > All strings in JSON need to be escaped, including the keys in dictionaries / > objects. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 719aa964a536cf02dbd2de440157de487ec703b1 > > Diff: https://reviews.apache.org/r/26723/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Cody Maloney > >
