----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26701/#review56656 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/26701/#comment97065> s/unacknowleded/unacknowledged/ src/master/master.cpp <https://reviews.apache.org/r/26701/#comment97066> When would the uuids ever be different? If the scheduler re-acked a previous terminal update when the master expected to be on a second terminal update/ack? src/master/master.cpp <https://reviews.apache.org/r/26701/#comment97063> s/do prevent/do, prevent/ src/messages/messages.proto <https://reviews.apache.org/r/26701/#comment97057> s/lateset/latest/ - Adam B On Oct. 14, 2014, 11:06 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26701/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 11:06 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1799 and MESOS-1817 > https://issues.apache.org/jira/browse/MESOS-1799 > https://issues.apache.org/jira/browse/MESOS-1817 > > > Repository: mesos-git > > > Description > ------- > > Master now maintains the latest and unacknowledged states of the task. > > > Diffs > ----- > > src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205 > src/master/master.cpp cb46cec0674b3aa031450c5b4f48f4f8bb92767d > src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99 > src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd > > Diff: https://reviews.apache.org/r/26701/diff/ > > > Testing > ------- > > make check > > Ran the new test 1000 times. > > > Thanks, > > Vinod Kone > >
