> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 2811-2816 > > <https://reviews.apache.org/r/26701/diff/3/?file=723865#file723865line2811> > > > > Isn't there a bit more to this comment? > > > > If this is a 0.21.0 master and there are 0.20.0 slaves, this all makes > > sense (the 0.20.0 slaves will not send this field when re-registering so we > > won't have it here as you said). > > > > However, if this is a 0.21.0 master and there are 0.21.0 slaves, then > > the state would have been set when the slave re-registered with the `Task`, > > right..? > > > > We never unset the unacknowledged state when an acknowledgement occurs > > on the slave either. "unacknowledged" now seems a bit confusing. > > > > Let's chat on Monday so I can understand this a bit better :) > > Vinod Kone wrote: > The unacknowledged state of the task will be set by the 0.21.0 *master* > when it receives an update from either 0.20.0 or 0.21.0 slave. That is why > this comment doesn't talk about the slave versions.
Hm.. per our chat, can you update this to be an ERROR log, since this should only be possible when 0.20.0 slaves are present? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26701/#review57285 ----------------------------------------------------------- On Oct. 20, 2014, 11:57 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26701/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 11:57 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1799 and MESOS-1817 > https://issues.apache.org/jira/browse/MESOS-1799 > https://issues.apache.org/jira/browse/MESOS-1817 > > > Repository: mesos-git > > > Description > ------- > > Master now maintains the latest and unacknowledged states of the task. > > > Diffs > ----- > > src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205 > src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4 > src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd > > Diff: https://reviews.apache.org/r/26701/diff/ > > > Testing > ------- > > make check > > Ran the new test 1000 times. > > > Thanks, > > Vinod Kone > >
