----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26702/#review56674 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/26702/#comment97078> Should reconciliation on slave reregistration return to the slave each task's latest state, or its latest unacknowledged state? Would it ever matter? Looking at Slave::reregistered(), it seems it doesn't even look at the state. It just checks to see if the slave knows that taskID and sends back TASK_LOST if the task is unknown. src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/26702/#comment97079> Times(1) is implicit, unnecessary. src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/26702/#comment97080> Validate uuid? - Adam B On Oct. 14, 2014, 11:07 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26702/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 11:07 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1799 and MESOS-1817 > https://issues.apache.org/jira/browse/MESOS-1799 > https://issues.apache.org/jira/browse/MESOS-1817 > > > Repository: mesos-git > > > Description > ------- > > Master responds to reconciliation requests with unacknowledged state of task > instead of latest state. > > > Diffs > ----- > > src/master/master.cpp cb46cec0674b3aa031450c5b4f48f4f8bb92767d > src/tests/reconciliation_tests.cpp 400c5c035a2cadd408636021aafb3888546f0081 > > Diff: https://reviews.apache.org/r/26702/diff/ > > > Testing > ------- > > make check > > Ran new test 1000 times. > > > Thanks, > > Vinod Kone > >
