> On Oct. 15, 2014, 7:41 a.m., Adam B wrote: > > src/master/master.cpp, lines 3920-3927 > > <https://reviews.apache.org/r/26702/diff/1/?file=720980#file720980line3920> > > > > Should reconciliation on slave reregistration return to the slave each > > task's latest state, or its latest unacknowledged state? Would it ever > > matter? > > Looking at Slave::reregistered(), it seems it doesn't even look at the > > state. It just checks to see if the slave knows that taskID and sends back > > TASK_LOST if the task is unknown.
For consistency, reconciliation requests should always include the latest unacknowledged state, because reconciliation is always based on unacknowledged state not latest state (to avoid out of order updates). Here, technically it doesn't matter because slave ignores it. But that needs non-local reasoning to understand. I would rather we keep the semantics consistent. > On Oct. 15, 2014, 7:41 a.m., Adam B wrote: > > src/tests/reconciliation_tests.cpp, line 851 > > <https://reviews.apache.org/r/26702/diff/1/?file=720981#file720981line851> > > > > Validate uuid? Reconciliation updates generate new uuids. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26702/#review56674 ----------------------------------------------------------- On Oct. 14, 2014, 6:07 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26702/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 6:07 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1799 and MESOS-1817 > https://issues.apache.org/jira/browse/MESOS-1799 > https://issues.apache.org/jira/browse/MESOS-1817 > > > Repository: mesos-git > > > Description > ------- > > Master responds to reconciliation requests with unacknowledged state of task > instead of latest state. > > > Diffs > ----- > > src/master/master.cpp cb46cec0674b3aa031450c5b4f48f4f8bb92767d > src/tests/reconciliation_tests.cpp 400c5c035a2cadd408636021aafb3888546f0081 > > Diff: https://reviews.apache.org/r/26702/diff/ > > > Testing > ------- > > make check > > Ran new test 1000 times. > > > Thanks, > > Vinod Kone > >
