----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26727/#review57022 -----------------------------------------------------------
What testing did you do? Also, let's use another term than 'hooked' src/module/manager.hpp <https://reviews.apache.org/r/26727/#comment97483> I raised a question in ::create() - what happens if a user specifies a module which is not an isolator? Can you check it? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/26727/#comment97482> Is that check enough? It is not necessarily an isolator module? Can we templetize the contains so we can check the type/kind too? - Niklas Nielsen On Oct. 16, 2014, 12:22 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26727/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 12:22 p.m.) > > > Review request for mesos, Ian Downes and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Hooked Isolator module to mesos containerizer. > > > Diffs > ----- > > src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > > Diff: https://reviews.apache.org/r/26727/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
