----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26727/#review57886 -----------------------------------------------------------
In testing done: I raised a question in the --isolation test patch - I don't think you exercised the code? Have you tried manually to use the --isolation flag on the slave? - Niklas Nielsen On Oct. 22, 2014, 12:49 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26727/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 12:49 p.m.) > > > Review request for mesos, Ian Downes and Niklas Nielsen. > > > Bugs: MESOS-1931 > https://issues.apache.org/jira/browse/MESOS-1931 > > > Repository: mesos-git > > > Description > ------- > > If an Isolator type is not found in the default list, the code now queries > ModuleManager and creates a module instance if found. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > > Diff: https://reviews.apache.org/r/26727/diff/ > > > Testing > ------- > > Tested it in along with --isolation flag for mesos tests. > > > Thanks, > > Kapil Arya > >
