Yes - it turned out not to be enough. Will disable tests so we have more time to fix this properly.
Niklas On 16 October 2014 16:20, Vinod Kone <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26838/#review57041 > ----------------------------------------------------------- > > > > src/tests/module_tests.cpp > <https://reviews.apache.org/r/26838/#comment97508> > > What happens if this test fails and this line doesn't get executed? > Does it affect other tests? If yes, thats bad. > > You should test fixture SetUp and TearDown to do these kind of resets. > > > - Vinod Kone > > > On Oct. 16, 2014, 11:13 p.m., Kapil Arya wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/26838/ > > ----------------------------------------------------------- > > > > (Updated Oct. 16, 2014, 11:13 p.m.) > > > > > > Review request for mesos and Niklas Nielsen. > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > The tests were changing the Mesos API and library version without > resetting back to the valid string. This caused the subsequent tests to > fail. The fix is to reset the version after the test is done. > > > > > > Diffs > > ----- > > > > src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 > > > > Diff: https://reviews.apache.org/r/26838/diff/ > > > > > > Testing > > ------- > > > > Reproduced the test with --gtest_shuffle, and verified that the patch > fixes the problem. > > > > > > Thanks, > > > > Kapil Arya > > > > > >
