> On Oct. 16, 2014, 4:20 p.m., Vinod Kone wrote: > > src/tests/module_tests.cpp, line 332 > > <https://reviews.apache.org/r/26838/diff/1/?file=723475#file723475line332> > > > > What happens if this test fails and this line doesn't get executed? > > Does it affect other tests? If yes, thats bad. > > > > You should test fixture SetUp and TearDown to do these kind of resets.
Most definitely - I disabled those tests for now so we can get them fixed properly (without being too hasty). - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26838/#review57041 ----------------------------------------------------------- On Oct. 16, 2014, 4:13 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26838/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 4:13 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > The tests were changing the Mesos API and library version without resetting > back to the valid string. This caused the subsequent tests to fail. The fix > is to reset the version after the test is done. > > > Diffs > ----- > > src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 > > Diff: https://reviews.apache.org/r/26838/diff/ > > > Testing > ------- > > Reproduced the test with --gtest_shuffle, and verified that the patch fixes > the problem. > > > Thanks, > > Kapil Arya > >
