----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26906/#review57261 -----------------------------------------------------------
Patch looks great! Reviews applied: [26903, 26904, 26855, 26906] All tests passed. - Mesos ReviewBot On Oct. 18, 2014, 1:58 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26906/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2014, 1:58 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Since, there is no reliable method of converting a template type to a > string, we create an temporary object of the given kind and compare the > "kind" fields of the temporary object with that of the one being > created. > > > Diffs > ----- > > src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d > src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 > > Diff: https://reviews.apache.org/r/26906/diff/ > > > Testing > ------- > > Added a new test and ran make check. > > > Thanks, > > Kapil Arya > >
