----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26906/#review57644 -----------------------------------------------------------
src/module/manager.hpp <https://reviews.apache.org/r/26906/#comment98444> Why this include? src/module/manager.hpp <https://reviews.apache.org/r/26906/#comment98445> Align according to http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Boolean_Expressions src/module/manager.hpp <https://reviews.apache.org/r/26906/#comment98446> Thanks for the comment! Would it make sense to denote what the 6 NULLs are? (author, version, ...) so if/when more fields are added to the module struct in the future, it is easy to spot/correct this statement too. src/tests/module_tests.cpp <https://reviews.apache.org/r/26906/#comment98447> s/Test/Verify/ ? - Niklas Nielsen On Oct. 20, 2014, 6:21 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26906/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 6:21 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Since, there is no reliable method of converting a template type to a > string, we create an temporary object of the given kind and compare the > "kind" fields of the temporary object with that of the one being > created. > > > Diffs > ----- > > src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d > src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 > > Diff: https://reviews.apache.org/r/26906/diff/ > > > Testing > ------- > > Added a new test and ran make check. > > > Thanks, > > Kapil Arya > >
