----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26914/#review57318 -----------------------------------------------------------
Bad patch! Reviews applied: [26914] Failed command: ./support/apply-review.sh -n -r 26914 Error: --2014-10-20 12:00:38-- https://reviews.apache.org/r/26914/diff/raw/ Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74 Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 28930 (28K) [text/x-patch] Saving to: '26914.patch' 0K .......... .......... ........ 100% 878K=0.03s 2014-10-20 12:00:38 (878 KB/s) - '26914.patch' saved [28930/28930] 26914.patch:16: trailing whitespace. warning: 1 line adds whitespace errors. Successfully applied: Right now at Mesos UI, link are hardcoded to http:// . It should not be hardcoded so that it can support https link. That is done. https is also supported now, the static http case modified by appropriate if else clause. Review: https://reviews.apache.org/r/26914 src/webui/master/static/js/controllers.js:17: trailing whitespace. + Failed to commit patch - Mesos ReviewBot On Oct. 20, 2014, 11:40 a.m., Aditi Bhatnagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26914/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 11:40 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1825 > https://issues.apache.org/jira/browse/MESOS-1825 > > > Repository: mesos-git > > > Description > ------- > > https is also supported now, the static http case modified by appropriate if > else clause. > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > 41a70a80442501a2bf7b217939dbe504662941d2 > src/webui/master/static/js/controllers.js~ PRE-CREATION > > Diff: https://reviews.apache.org/r/26914/diff/ > > > Testing > ------- > > > Thanks, > > Aditi Bhatnagar > >
