----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26914/#review57347 -----------------------------------------------------------
src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/26914/#comment97999> whitespace src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/26914/#comment98000> '//' + host + ... is safer. src/webui/master/static/js/controllers.js~ <https://reviews.apache.org/r/26914/#comment97998> remove your temporary files and be careful not to git add them. you should use the gitignore template in the root of the project. - Dominic Hamon On Oct. 20, 2014, 4:40 a.m., Aditi Bhatnagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26914/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 4:40 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1825 > https://issues.apache.org/jira/browse/MESOS-1825 > > > Repository: mesos-git > > > Description > ------- > > https is also supported now, the static http case modified by appropriate if > else clause. > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > 41a70a80442501a2bf7b217939dbe504662941d2 > src/webui/master/static/js/controllers.js~ PRE-CREATION > > Diff: https://reviews.apache.org/r/26914/diff/ > > > Testing > ------- > > > Thanks, > > Aditi Bhatnagar > >
