----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26903/#review57385 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/26903/#comment98073> I think the idea was to avoid repetition of #ifdef __linux__ return "LD_LIBRARY_PATH"; #else return "DYLD_LIBRARY_PATH"; #endif in paths() and sePaths(). If we don't mind repetition, then I think we should remove ldLibraryPath(). Alternatively, we can rename it to environmentVariable(). - Kapil Arya On Oct. 18, 2014, 3:04 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26903/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2014, 3:04 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Also added a utility function to expand a library name to a filename > by prefixing "lib" and adding the default extension. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 63bda7a87e24e1696f3e7bb0206c551ce39dfe27 > > Diff: https://reviews.apache.org/r/26903/diff/ > > > Testing > ------- > > Ran make check. > > > Thanks, > > Kapil Arya > >
