> On Oct. 20, 2014, 1:56 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 1283 > > <https://reviews.apache.org/r/26903/diff/2/?file=725229#file725229line1283> > > > > How about flatten it to os::libraries::expand() ? > > Kapil Arya wrote: > It's not clear what expand() would mean but expandName() is clearer. > expandLibraryName() would have been the best, though. > > Niklas Nielsen wrote: > library is already a part of the namespace, so that would become > redundant? > I mostly suggested it because you won't have other conflicting > expand(std::string name) in that namespace and it would be more concise. > > Anyway, it is not a biggy; feel free to drop the issue if you want to > keep expandName
I think the idea was to avoid repetition of ifdef linux return "LD_LIBRARY_PATH"; else return "DYLD_LIBRARY_PATH"; endif in paths() and sePaths(). If we don't mind repetition, then I think we should remove ldLibraryPath(). Alternatively, we can rename it to environmentVariable(). - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26903/#review57372 ----------------------------------------------------------- On Oct. 18, 2014, 3:04 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26903/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2014, 3:04 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Also added a utility function to expand a library name to a filename > by prefixing "lib" and adding the default extension. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 63bda7a87e24e1696f3e7bb0206c551ce39dfe27 > > Diff: https://reviews.apache.org/r/26903/diff/ > > > Testing > ------- > > Ran make check. > > > Thanks, > > Kapil Arya > >
