> On Oct. 20, 2014, 4:35 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/docker.cpp, lines 1539-1548 > > <https://reviews.apache.org/r/26861/diff/2/?file=724760#file724760line1539> > > > > Does this change belong here? I see it's reverted in > > https://reviews.apache.org/r/26862?
yes, It is part of the scheduling remove patch. Although later I changed it to call kill always, but still never remove it until gc runs. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26861/#review57309 ----------------------------------------------------------- On Oct. 17, 2014, 7:32 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26861/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 7:32 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Instead of removing docker containers right after reap, schedule it to be > removed later. > > > Diffs > ----- > > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/docker.cpp 9a29489 > src/slave/flags.hpp 03c62a2 > > Diff: https://reviews.apache.org/r/26861/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
