----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26861/#review59391 -----------------------------------------------------------
Ship it! src/slave/constants.hpp <https://reviews.apache.org/r/26861/#comment100657> Since you ultimatly call Docker::rm, let's s/cleanup/remove/g. - Benjamin Hindman On Oct. 29, 2014, 12:02 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26861/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 12:02 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Instead of removing docker containers right after reap, schedule it to be > removed later. > > > Diffs > ----- > > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/docker.cpp 9a29489 > src/slave/flags.hpp f7a8cde > > Diff: https://reviews.apache.org/r/26861/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
