> On Oct. 21, 2014, 2:18 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/composing.cpp, line 594 > > <https://reviews.apache.org/r/26486/diff/3/?file=726514#file726514line594> > > > > What if destroy is called twice? I think this breaks your invariant?
If the container is already launched, then it's fine since we remove the container from the map. If it's launching, then yes the current code forwads it twice. I added a check to only forward it once. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26486/#review57522 ----------------------------------------------------------- On Oct. 20, 2014, 10:08 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26486/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 10:08 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1884 and MESOS-1915 > https://issues.apache.org/jira/browse/MESOS-1884 > https://issues.apache.org/jira/browse/MESOS-1915 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/26486 > > > Diffs > ----- > > src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 > src/slave/containerizer/composing.cpp > 9022700b628d9746a6a8a17c9fbf1b1988da6fca > src/tests/composing_containerizer_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26486/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
