> On Oct. 21, 2014, 2:18 a.m., Benjamin Hindman wrote: > > src/tests/composing_containerizer_tests.cpp, lines 156-157 > > <https://reviews.apache.org/r/26486/diff/3/?file=726515#file726515line156> > > > > Cool, let's test this part too! I think all you will need is the > > following above: > > > > EXPECT_CALL(*mockContainerizer2, launch(_, _, _, _, _, _, _, _)) > > .Times(0); > > > > And then this at the bottom after AWAIT_READY(destroy); > > > > > > launchPromise.set(false); > > AWAIT_READY_EQ(false, launch);
I'm actually throwing a failure in the end. I don't think false is the right choice still false signals that we don't support this TaskInfo, but the truth is that it was destroyed! - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26486/#review57522 ----------------------------------------------------------- On Oct. 21, 2014, 4:42 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26486/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 4:42 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1884 and MESOS-1915 > https://issues.apache.org/jira/browse/MESOS-1884 > https://issues.apache.org/jira/browse/MESOS-1915 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/26486 > > > Diffs > ----- > > src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 > src/slave/containerizer/composing.cpp > 9022700b628d9746a6a8a17c9fbf1b1988da6fca > src/tests/composing_containerizer_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26486/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
