----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27040/#review57798 -----------------------------------------------------------
Bad patch! Reviews applied: [27040] Failed command: ./support/apply-review.sh -n -r 27040 Error: --2014-10-22 15:12:21-- https://reviews.apache.org/r/27040/diff/raw/ Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74 Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 7434 (7.3K) [text/x-patch] Saving to: '27040.patch' 0K ....... 100% 108M=0s 2014-10-22 15:12:21 (108 MB/s) - '27040.patch' saved [7434/7434] Successfully applied: Replace hard-coded reap interval with a constant Replace the hard-coded value for the maximal and minimum reap intervals with the constants from reap.hpp Review: https://reviews.apache.org/r/27040 Checking 2 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo 3rdparty/libprocess/include/process/reap.hpp:14: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] 3rdparty/libprocess/include/process/reap.hpp:15: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] Total errors found: 2 Failed to commit patch - Mesos ReviewBot On Oct. 22, 2014, 2:45 p.m., Aditi Bhatnagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27040/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 2:45 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1935 > https://issues.apache.org/jira/browse/MESOS-1935 > > > Repository: mesos-git > > > Description > ------- > > Replace the hard-coded value for the maximal and minimum reap intervals with > the constants from reap.hpp > > > Diffs > ----- > > 3rdparty/libprocess/include/process/reap.hpp 5e5051a > 3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION > 3rdparty/libprocess/src/reap.cpp afd956b > 3rdparty/libprocess/src/reap.cpp~ PRE-CREATION > > Diff: https://reviews.apache.org/r/27040/diff/ > > > Testing > ------- > > > Thanks, > > Aditi Bhatnagar > >
