> On Oct. 22, 2014, 5:26 p.m., Ben Mahler wrote: > > There is already a constant, MESOS-1935 is to ensure that code that > > previously hardcoded Seconds(1) now uses MAX_REAP_INTERVAL from reap.hpp. > > Aditi Bhatnagar wrote: > Sorry, but I didn't find the constants in > https://github.com/apache/mesos/blob/4693728e4f604a1cff6f01d5f2d8f0ec60eb2f96/3rdparty/libprocess/include/process/reap.hpp > .
`MAX_REAP_INTERVAL()` acts as a constant. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27040/#review57826 ----------------------------------------------------------- On Oct. 22, 2014, 2:45 p.m., Aditi Bhatnagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27040/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 2:45 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1935 > https://issues.apache.org/jira/browse/MESOS-1935 > > > Repository: mesos-git > > > Description > ------- > > Replace the hard-coded value for the maximal and minimum reap intervals with > the constants from reap.hpp > > > Diffs > ----- > > 3rdparty/libprocess/include/process/reap.hpp 5e5051a > 3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION > 3rdparty/libprocess/src/reap.cpp afd956b > 3rdparty/libprocess/src/reap.cpp~ PRE-CREATION > > Diff: https://reviews.apache.org/r/27040/diff/ > > > Testing > ------- > > > Thanks, > > Aditi Bhatnagar > >
