----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review57842 -----------------------------------------------------------
There are 2 things happening here, code movement and making it modular. Can you split this into 2 patches? It'll be easier to review. Also, can you expand on the description in the review ? - Vinod Kone On Oct. 21, 2014, 12:59 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26857/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 12:59 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > Introducing the CRAM-MD5 SASL authenticator module based on the former > sasl/authenticator. > > > Diffs > ----- > > src/Makefile.am c44a9ad > src/authentication/authenticator.hpp PRE-CREATION > src/authentication/cram_md5/authenticator/authenticator.hpp PRE-CREATION > src/authentication/cram_md5/authenticator/authenticator.cpp PRE-CREATION > src/module/manager.cpp 2727fe0 > src/sasl/authenticator.hpp 6f4d3db > src/sasl/secrets.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26857/diff/ > > > Testing > ------- > > make check > > NOTE all three CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
