> On Oct. 22, 2014, 6:07 p.m., Vinod Kone wrote: > > There are 2 things happening here, code movement and making it modular. Can > > you split this into 2 patches? It'll be easier to review. > > > > Also, can you expand on the description in the review ?
New round of review proposals upcoming. Totally makes sense to split this further and add a "reorganizing" proposal as well. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review57842 ----------------------------------------------------------- On Oct. 24, 2014, 1:28 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26857/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 1:28 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > Introducing the CRAM-MD5 SASL authenticator module based on the former > sasl/authenticator. > > > Diffs > ----- > > src/Makefile.am 2617f77 > src/authentication/authenticator.hpp PRE-CREATION > src/authentication/cram_md5/authenticator.hpp 3a2a97d > src/examples/test_authenticator_module.cpp PRE-CREATION > src/module/manager.cpp 1613e39 > > Diff: https://reviews.apache.org/r/26857/diff/ > > > Testing > ------- > > make check > > NOTE all three CRAM-MD5 authenticator module related RRs need to get applied > before running make check. > > > Thanks, > > Till Toenshoff > >
