> On Oct. 17, 2014, 2:55 p.m., Niklas Nielsen wrote: > > Are you sure this will work? > > > > Try take a look at: > > https://github.com/apache/mesos/blob/master/src/tests/mesos.cpp#L414 - it > > looks like we need to do a bit more.
The idea here is to override any other flags if the user has specified isolation flags on the command-line. However ,if the user has specified some isolation that requires a special environment, such as cgroups, then it will currently fail. I am not sure what is a good way to address this. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26797/#review57189 ----------------------------------------------------------- On Oct. 22, 2014, 3:50 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26797/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 3:50 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: MESOS-1951 > https://issues.apache.org/jira/browse/MESOS-1951 > > > Repository: mesos-git > > > Description > ------- > > This allows the user to specify custom isolation for the slaves. > > > Diffs > ----- > > src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337 > src/tests/mesos.cpp bff10d23f767785d5616c2384dc34d2c1f0cf9e0 > > Diff: https://reviews.apache.org/r/26797/diff/ > > > Testing > ------- > > Tested by hand using the following commandline: > ./bin/mesos-tests.sh --isolation="posix/cpu" > > > Thanks, > > Kapil Arya > >
