----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26797/#review58081 -----------------------------------------------------------
Ship it! Modulo the request for comment src/tests/flags.hpp <https://reviews.apache.org/r/26797/#comment98972> Can you add comment of where the copy/pasted help text originates from? It's important that we remember to update both places when slave isolation flags changes. - Niklas Nielsen On Oct. 22, 2014, 12:50 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26797/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 12:50 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: MESOS-1951 > https://issues.apache.org/jira/browse/MESOS-1951 > > > Repository: mesos-git > > > Description > ------- > > This allows the user to specify custom isolation for the slaves. > > > Diffs > ----- > > src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337 > src/tests/mesos.cpp bff10d23f767785d5616c2384dc34d2c1f0cf9e0 > > Diff: https://reviews.apache.org/r/26797/diff/ > > > Testing > ------- > > Tested by hand using the following commandline: > ./bin/mesos-tests.sh --isolation="posix/cpu" > > > Thanks, > > Kapil Arya > >
