> On Oct. 23, 2014, 3:18 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 36 > > <https://reviews.apache.org/r/27113/diff/1/?file=731328#file731328line36> > > > > I thought we weren't checking for this feature yet.. > > > > Looks like the first one introduced in the code base! > > > > ``` > > ? mesos git:(master) ? grep -R unique_ptr 3rdparty > > 3rdparty/libprocess/3rdparty/stout/README.md:std::unique_ptr (although, > > likely wrapped as Owned) in order to > > 3rdparty/libprocess/include/process/c++11/dispatch.hpp:#include > > <memory> // TODO(benh): Replace shared_ptr with unique_ptr. > > 3rdparty/libprocess/include/process/c++11/dispatch.hpp:// will probably > > change in the future to unique_ptr (or a variant). > > 3rdparty/libprocess/include/process/dispatch.hpp:#include > > <stout/memory.hpp> // TODO(benh): Replace shared_ptr with unique_ptr. > > 3rdparty/libprocess/include/process/dispatch.hpp:// will probably > > change in the future to unique_ptr (or a variant). > > 3rdparty/libprocess/include/process/event.hpp:#include > > <stout/memory.hpp> // TODO(benh): Replace shared_ptr with unique_ptr. > > 3rdparty/libprocess/include/process/future.hpp:#include > > <stout/memory.hpp> // TODO(benh): Replace shared_ptr with unique_ptr. > > 3rdparty/libprocess/include/process/owned.hpp:// unique_ptr semantics. > > Consequently, each usage of Owned that > > 3rdparty/libprocess/include/process/run.hpp:#include <stout/memory.hpp> > > // TODO(benh): Replace shared_ptr with unique_ptr. > > 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4: int > > foo(std::unique_ptr<int> i) > > 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4: > > std::unique_ptr<int> i(new int()); > > 3rdparty/libprocess/src/process.cpp:#include <stout/memory.hpp> // > > TODO(benh): Replace shared_ptr with unique_ptr. > > ```
https://issues.apache.org/jira/browse/MESOS-1771 should be added as a blocker for this issue. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/#review58124 ----------------------------------------------------------- On Oct. 23, 2014, 2:54 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27113/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 2:54 p.m.) > > > Review request for mesos, Ben Mahler and Niklas Nielsen. > > > Bugs: MESOS-1980 > https://issues.apache.org/jira/browse/MESOS-1980 > > > Repository: mesos-git > > > Description > ------- > > Add a comment to BenchmarkProcess. > Remove setLink() as it is not strictly necessary. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/benchmarks.cpp 79a650b > > Diff: https://reviews.apache.org/r/27113/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
