> On Oct. 23, 2014, 10:18 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 149
> > <https://reviews.apache.org/r/27113/diff/1/?file=731328#file731328line149>
> >
> >     Why is this a set, don't you only need to know whether you're linked? 
> > (i.e. boolean).
> >     
> >     This is just 1:1 client:server in terms of messaging, right? It's a bit 
> > confusing as to why there is 1 'other', but many 'linkedPorts'..

There are many clients connecting to a single server. The server keeps track of 
which clients it has linked with to ensure that it links back to all of them.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27113/#review58124
-----------------------------------------------------------


On Oct. 24, 2014, 3:09 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27113/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 3:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1980
>     https://issues.apache.org/jira/browse/MESOS-1980
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add a comment to BenchmarkProcess.
> Remove setLink() as it is not strictly necessary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 79a650b 
> 
> Diff: https://reviews.apache.org/r/27113/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to