----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26622/#review58149 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/26622/#comment99074> The comments here are confusing. We need to explictly call out that the reason we copying uris, environments and user is because we do not perform fetch/setting environments/change user in mesos-executor. We reply on containerizer to do that for mesos-executor so that the task can inherit those settings. src/slave/slave.cpp <https://reviews.apache.org/r/26622/#comment99066> +1 src/tests/slave_tests.cpp <https://reviews.apache.org/r/26622/#comment99076> It would be great if you can write an end-to-end test so that we can verify that the 'command' actually runs correctly with shell=false and has an argument list (refer to the following test). - Jie Yu On Oct. 18, 2014, 4:40 a.m., R.B. Boyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26622/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2014, 4:40 a.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-1873 > https://issues.apache.org/jira/browse/MESOS-1873 > > > Repository: mesos-git > > > Description > ------- > > Basically if you use "shell=false" with a non-empty argument list and the > Command Executor it is completely broken. > > When we clone the env vars to fork "mesos-executor" all of the original cmd > args are cloned as well (unintentionally) due to some protocol-buffer merge > shenanigans. > > Don't pass task-related arguments to mesos-executor. > > The description on the linked jira ticket goes into more detail. > > > Diffs > ----- > > src/slave/slave.cpp 0e342ed > src/tests/slave_tests.cpp f585bdd > > Diff: https://reviews.apache.org/r/26622/diff/ > > > Testing > ------- > > make check > > added new test "SlaveTest.GetExecutorInfo" verifying the explicit desired > behavior. > > > Thanks, > > R.B. Boyer > >
