-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 8:30 p.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy Chen.
Changes
-------
Switched CommandInfo to whitelist fields rather than using MergeFrom. Also
added an end-to-end test.
Bugs: MESOS-1873
https://issues.apache.org/jira/browse/MESOS-1873
Repository: mesos-git
Description
-------
Basically if you use "shell=false" with a non-empty argument list and the
Command Executor it is completely broken.
When we clone the env vars to fork "mesos-executor" all of the original cmd
args are cloned as well (unintentionally) due to some protocol-buffer merge
shenanigans.
Don't pass task-related arguments to mesos-executor.
The description on the linked jira ticket goes into more detail.
Diffs (updated)
-----
src/slave/slave.cpp 55e5264
src/tests/slave_tests.cpp a1bd00c
Diff: https://reviews.apache.org/r/26622/diff/
Testing
-------
make check
added new test "SlaveTest.GetExecutorInfo" verifying the explicit desired
behavior.
Thanks,
R.B. Boyer
