----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26622/#review58287 -----------------------------------------------------------
src/tests/slave_tests.cpp <https://reviews.apache.org/r/26622/#comment99235> I think I'll yank this out since this is already fixed. src/tests/slave_tests.cpp <https://reviews.apache.org/r/26622/#comment99236> Just tried bin/ls on OSX and realize Mac's ls has no --author flag so this is going to fail on OSX. It's ok if we don't support it but then we need to wrap the test in #ifdef __linux__ - Timothy Chen On Oct. 24, 2014, 2:04 a.m., R.B. Boyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26622/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 2:04 a.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-1873 > https://issues.apache.org/jira/browse/MESOS-1873 > > > Repository: mesos-git > > > Description > ------- > > Basically if you use "shell=false" with a non-empty argument list and the > Command Executor it is completely broken. > > When we clone the env vars to fork "mesos-executor" all of the original cmd > args are cloned as well (unintentionally) due to some protocol-buffer merge > shenanigans. > > Don't pass task-related arguments to mesos-executor. > > The description on the linked jira ticket goes into more detail. > > > Diffs > ----- > > src/slave/slave.cpp 55e5264 > src/tests/slave_tests.cpp a1bd00c > > Diff: https://reviews.apache.org/r/26622/diff/ > > > Testing > ------- > > make check > > added new test "SlaveTest.GetExecutorInfo" verifying the explicit desired > behavior. > > > Thanks, > > R.B. Boyer > >
