----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/#review58419 -----------------------------------------------------------
Ship it! src/tests/ns_tests.cpp <https://reviews.apache.org/r/27091/#comment99423> Can you just expect !namespaces.empty() src/tests/setns_test_helper.hpp <https://reviews.apache.org/r/27091/#comment99418> I guess you're using subcommand because you're anticipating commands here other than "test"? Can you just use a main? src/tests/setns_test_helper.hpp <https://reviews.apache.org/r/27091/#comment99416> string include needed src/tests/setns_test_helper.cpp <https://reviews.apache.org/r/27091/#comment99415> include these please, also include try and foreach src/tests/setns_test_helper.cpp <https://reviews.apache.org/r/27091/#comment99421> Maybe a note as to why pid is special here? - Ben Mahler On Oct. 24, 2014, 9:53 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27091/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 9:53 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > A following commit will remove this code from stout. > > > Diffs > ----- > > src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 > src/linux/ns.hpp PRE-CREATION > src/slave/containerizer/isolators/network/port_mapping.cpp > 62ca9bca08de55f19bfff7b8828dfa4fb6c51f30 > src/tests/ns_tests.cpp PRE-CREATION > src/tests/setns_test_helper.hpp PRE-CREATION > src/tests/setns_test_helper.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/27091/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
