----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/#review58201 -----------------------------------------------------------
Looks like this isn't a pure code movement from a few leftover includes and the tests, can you make it just a movement? I also left some commments for cleaning this stuff up. Let's try to do the following: (1) Pure code movement. (2) Cleanups, per my comments below. Much appreciated!! src/Makefile.am <https://reviews.apache.org/r/27091/#comment99150> How about namespaces.hpp and namespaces_tests.cpp? Then we can clean up the function naming, and avoid all the 'ns' acronyms! ``` ns::namespaces ns::getns ns::setns ns::nstype ``` ``` namespaces::available namespaces::get namespaces::set namespaces::flag ``` src/linux/ns.hpp <https://reviews.apache.org/r/27091/#comment99155> Unused? src/linux/ns.hpp <https://reviews.apache.org/r/27091/#comment99151> Looks like this can be hidden in an 'internal' namespace? src/linux/ns.hpp <https://reviews.apache.org/r/27091/#comment99157> s/ns/namespace/ for the argument src/linux/ns.hpp <https://reviews.apache.org/r/27091/#comment99152> Not sure why an 'if' block wasn't used here.. seems like that code would be simpler than using the map? src/linux/ns.hpp <https://reviews.apache.org/r/27091/#comment99158> s/ns/namespace/ for the argument src/linux/ns.hpp <https://reviews.apache.org/r/27091/#comment99154> All the O_CLOEXEC handling here is no longer necessary, thanks to os::open.hpp. src/linux/ns.hpp <https://reviews.apache.org/r/27091/#comment99159> s/ret/status/ or s/ret/result/ Who wrote this code?? :) src/linux/ns.hpp <https://reviews.apache.org/r/27091/#comment99160> s/ns/namespace/ for the argument src/tests/ns_tests.cpp <https://reviews.apache.org/r/27091/#comment99156> Does this file exist?? - Ben Mahler On Oct. 24, 2014, 1:20 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27091/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 1:20 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > A following commit will remove this code from stout. > > > Diffs > ----- > > src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 > src/linux/ns.hpp PRE-CREATION > src/slave/containerizer/isolators/network/port_mapping.cpp > 62ca9bca08de55f19bfff7b8828dfa4fb6c51f30 > src/tests/ns_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/27091/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
